fix(eager): Use isResolvableObject instead of contains before trying to build hashcode#1286
Merged
jasmith-hs merged 2 commits intomasterfrom Feb 24, 2026
Merged
fix(eager): Use isResolvableObject instead of contains before trying to build hashcode#1286jasmith-hs merged 2 commits intomasterfrom
jasmith-hs merged 2 commits intomasterfrom
Conversation
hashcode 1. using `contains` can cause a StackOverflowError 2. If the depth grows very deep, running hashCode can be quite slow, using isResolvableObject will break out before going into too much depth and we won't use hashCode In cases where we can't use the hashCode of such objects, we just aren't able to check for changes to them
jasmith-hs
changed the title
rewaddell
approved these changes
Feb 23, 2026
mnobile-hs
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containscan cause a StackOverflowErrorIn cases where we can't use the hashCode of such objects, we just aren't able to check for changes to them